For 4.2.0 JGroups message bundling was disabled pending investigation of JGRP-497. That is fixed in JGroups 2.4.1.SP4. Message bundling improves performance, so we should re-enable it.
Description
For 4.2.0 JGroups message bundling was disabled pending investigation of JGRP-497. That is fixed in JGroups 2.4.1.SP4. Message bundling improves performance, so we should re-enable it.
Rajesh Rajasekaran [07/Nov/07 11:34 AM]
Dominik, this issue should be fixed with the EAP4.3 beta build which includes JGroups 2.4.1.SP4
Please verify the issue and close it.
Brian, the config files are not changed. Can you take a look at it?
I am glad atleast this was brought to your attention now.
The jgroups upgrade is already in place in branch JBPAPP_4_2.
If you can change the config files, it will automatically be picked up in the next build for testing.
Rajesh Rajasekaran [07/Nov/07 11:55 AM]
Brian, the config files are not changed. Can you take a look at it?
I am glad atleast this was brought to your attention now.
The jgroups upgrade is already in place in branch JBPAPP_4_2.
If you can change the config files, it will automatically be picked up in the next build for testing.
Config files are changed on JBPAPP_4_2 to re-enable bundling. I'm resolving for 4.2.0.GA_CP02 as well under the assumption this will get onto the CP branch as part of the merge.
Assigning to Dominik per Rajesh's earlier comment.
Brian Stansberry [07/Nov/07 02:54 PM]
Config files are changed on JBPAPP_4_2 to re-enable bundling. I'm resolving for 4.2.0.GA_CP02 as well under the assumption this will get onto the CP branch as part of the merge.
Assigning to Dominik per Rajesh's earlier comment.
Dominik, Brian committed the config changes yesterday which is not available in the beta1 build. Please have this issue to be verified on the next build.
Rajesh Rajasekaran [08/Nov/07 08:57 AM]
Dominik, Brian committed the config changes yesterday which is not available in the beta1 build. Please have this issue to be verified on the next build.
Dominik Pospisil [20/Nov/07 03:43 AM]
Verified that bundling is enabled for all services except messaging. Is this intended?
*/deploy/jboss-messaging.sar/hsqldb-persistence-service.xml still has bundling disabled for both data and control channels.
I am going to return enable_bundling to 'false' on the cluster-service.xml stack:
1) This channel is not expected to have high concurrent load. Enabling bundling helps performance under high concurrent load but adds latency under low load.
2) Bundling was disabled in 4.0.5.GA; disabling it in 4.2 was not a "takeaway", so less reason to enable it now.
3) The added latency causes StatefulPassivationActivationUnitTestCase to fail with a timeout. That's just due to how the test is designed; the small bit of latency happens to get triggered thousands of times by a single thread.
#3 isn't a good enough reason to disable bundling, but it helps concentrate the mind on issue #1.
Brian Stansberry [21/Nov/07 12:13 PM]
I am going to return enable_bundling to 'false' on the cluster-service.xml stack:
1) This channel is not expected to have high concurrent load. Enabling bundling helps performance under high concurrent load but adds latency under low load.
2) Bundling was disabled in 4.0.5.GA; disabling it in 4.2 was not a "takeaway", so less reason to enable it now.
3) The added latency causes StatefulPassivationActivationUnitTestCase to fail with a timeout. That's just due to how the test is designed; the small bit of latency happens to get triggered thousands of times by a single thread.
#3 isn't a good enough reason to disable bundling, but it helps concentrate the mind on issue #1.
Task
Resolved
Minor
Re-enable JGroups message bundling
Please verify the issue and close it.